Make the HTTP server optional via ODR_WITH_HTTP_SERVER#601
Merged
Conversation
The HTTP server (src/odr/http_server.cpp, the `server` CLI, and its only dependency cpp-httplib) is self-contained: nothing else in libodr references HttpServer. Gate it behind a new ODR_WITH_HTTP_SERVER option (default ON, so the build is unchanged by default) so consumers that don't need it can drop the cpp-httplib dependency entirely. When OFF: cpp-httplib is not searched for or linked, http_server.cpp is not compiled, the `server` CLI target is not built, and the public http_server.hpp header is not installed (the API it declares isn't available). The dependency is wired as a single self-contained block next to the other optional dependencies (pdf2htmlEX, wvWare, libmagic), matching their find_package + target_sources + target_link_libraries + target_compile_definitions pattern.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbab044416
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Expose a matching with_http_server option (default True), guard the cpp-httplib requirement on it, and pass ODR_WITH_HTTP_SERVER into the toolchain, so Conan consumers can actually take the -DODR_WITH_HTTP_SERVER=OFF path and drop the cpp-httplib dependency (and its platform link requirements).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the HTTP server optional behind a new
ODR_WITH_HTTP_SERVERCMake option (defaultON, so the default build is unchanged).The HTTP server is self-contained —
src/odr/http_server.cpp, theserverCLI, and its only dependencycpp-httplib— and nothing else inlibodrreferencesHttpServer. Gating it lets consumers that don't need the server drop thecpp-httplibdependency entirely.This also sidesteps a link failure on Apple platforms: recent
cpp-httplibcompiles a CFHost-based DNS resolver that needsCoreFoundation/CFNetwork, which is awkward to satisfy for consumers that don't use the server at all (e.g. the iOS build).Behavior
With
-DODR_WITH_HTTP_SERVER=OFF:cpp-httplibis not searched for (find_package) or linkedhttp_server.cppis not compiledserverCLI target is not builthttp_server.hppheader is not installed (the API it declares isn't available)Notes
The dependency is wired as a single self-contained block next to the other optional dependencies (
pdf2htmlEX,wvWare,libmagic), following theirfind_package+target_sources+target_link_libraries+target_compile_definitionspattern.