Skip to content

feat: slash-and-burn Problem block built-in implementation#38751

Open
irfanuddinahmad wants to merge 4 commits into
masterfrom
irfanuddinahmad/slash-and-burn-problem-block
Open

feat: slash-and-burn Problem block built-in implementation#38751
irfanuddinahmad wants to merge 4 commits into
masterfrom
irfanuddinahmad/slash-and-burn-problem-block

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the built-in ProblemBlock shim (xmodule/capa_block.py) and all associated assets, completing the extraction of the Problem XBlock to xblocks_contrib. Part of the Slash-n-Burn Built-In XBlocks epic.

  • Deleted xmodule/capa_block.py (2481 LOC — _BuiltInProblemBlock class and shim)
  • Deleted xmodule/capa/ (deprecated safe_exec shim pointing to xblocks_contrib)
  • Deleted xmodule/js/src/capa/ JS files (display.js, imageinput.js, schematic.js)
  • Deleted xmodule/static/css-builtin-blocks/ProblemBlockDisplay.css
  • Deleted xmodule/tests/test_capa_block.py (directly tested _BuiltInProblemBlock)
  • Deleted lms/djangoapps/grades/tests/integration/test_problems.py (relied on reset_class shim)
  • Removed USE_EXTRACTED_PROBLEM_BLOCK Django setting toggle from openedx/envs/common.py
  • Updated CODE_JAIL_REST_SERVICE_REMOTE_EXEC to point directly to xblocks_contrib.problem.capa.safe_exec.remote_exec
  • Removed problem entrypoint from pyproject.toml
  • Removed ProblemBlockDisplay webpack entry from webpack.builtinblocks.config.js
  • Updated all ProblemBlock, SHOWANSWER, and generate_report_data imports/patches to use xblocks_contrib.problem

Test plan

  • Run pytest xmodule/tests/test_delay_between_attempts.py — no capa_block imports
  • Run pytest xmodule/tests/test_item_bank.py — ProblemBlock from xblocks_contrib
  • Run pytest xmodule/tests/test_library_content.py — ProblemBlock from xblocks_contrib
  • Run pytest cms/djangoapps/contentstore/tests/test_crud.py
  • Run pytest cms/djangoapps/contentstore/tests/test_contentstore.py
  • Run pytest lms/djangoapps/courseware/tests/test_block_render.py
  • Run pytest lms/djangoapps/instructor_task/tests/test_tasks_helper.py
  • Run pytest openedx/features/personalized_learner_schedules/show_answer/tests/
  • Verify Problem XBlocks render correctly in LMS and CMS

🤖 Generated with Claude Code

Closes openedx/public-engineering#540

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 11, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-problem-block branch from fcc939b to 356dc98 Compare June 11, 2026 12:53
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-problem-block branch from 20097bb to 46e90c6 Compare June 12, 2026 11:53
Irfan Ahmad and others added 4 commits June 12, 2026 21:55
Removes the built-in ProblemBlock shim and all associated assets now that
the extracted xblocks_contrib.problem.ProblemBlock is the production implementation.

- Delete xmodule/capa_block.py (_BuiltInProblemBlock + shim)
- Delete xmodule/capa/ (deprecated safe_exec shim pointing to xblocks_contrib)
- Delete xmodule/js/src/capa/ JS files (display, imageinput, schematic)
- Delete xmodule/static/css-builtin-blocks/ProblemBlockDisplay.css
- Delete xmodule/tests/test_capa_block.py (tested _BuiltInProblemBlock directly)
- Delete lms/djangoapps/grades/tests/integration/test_problems.py (used reset_class shim)
- Remove USE_EXTRACTED_PROBLEM_BLOCK toggle from openedx/envs/common.py
- Update CODE_JAIL_REST_SERVICE_REMOTE_EXEC to xblocks_contrib path
- Remove problem entrypoint from pyproject.toml
- Remove ProblemBlockDisplay webpack entry
- Update all ProblemBlock/SHOWANSWER imports to xblocks_contrib.problem

Part of epic #37819

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-problem-block branch from 46e90c6 to bebc423 Compare June 12, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

[Refactor] Slash-n-Burn Problem BuiltIn XBlock

3 participants