feat(client): configurable leaderboard and team stats columns

[ryanbarlow97]

Description:

• rips out some duped code, making tables use the same layout, where the only thing different is the row content.
• updated text to be emojis to save space
• updated columns to be as wide as they need to be
• updated cells to have left/right thin borders to read easier
• added more supported column types
• removed the + button to always show everyone, where the current player is either at the bottom or in the top 5
• added a cogwheel to change options
• can select different options for each menu type (player/team stats)

works fine on mobile, will probably need some future love though (has h-scroll, so all options can be seen by scrolling):

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

w.o.n

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds shared configurable column definitions for the leaderboard and team statistics. Users can select visible columns through a popover, with selections persisted independently in UserSettings. Both views now sort, aggregate, and render dynamically from the selected columns.

Changes

Configurable leaderboard columns

Layer / File(s)	Summary
Column definitions and defaults src/client/hud/layers/LeaderboardColumns.ts, src/core/game/LeaderboardConstants.ts, tests/LeaderboardColumns.test.ts	Defines typed column metadata, value formatters, registry ordering, lookup, defaults, and registry tests.
Persisted column selections src/core/game/UserSettings.ts, tests/UserSettings.test.ts	Stores validated leaderboard and team-statistics column IDs separately in local storage and tests defaults, filtering, fallback, ordering, and independence.
Column selection popover src/client/hud/layers/ColumnPicker.ts, resources/lang/en.json	Adds localized checkbox controls that preserve at least one selected column and emit ordered selection changes.
Configurable leaderboard rendering src/client/hud/layers/Leaderboard.ts	Uses selected column definitions for sorting, formatting, dynamic headers, grid sizing, and row cells.
Configurable team statistics src/client/hud/layers/TeamStats.ts, tests/TeamStats.test.ts	Aggregates selected columns across alive players, sorts teams by tiles, renders dynamic headers and cells, and tests aggregation.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant ColumnPicker
  participant Leaderboard
  participant TeamStats
  participant UserSettings
  User->>ColumnPicker: select visible columns
  ColumnPicker->>Leaderboard: dispatch columns-changed
  ColumnPicker->>TeamStats: dispatch columns-changed
  Leaderboard->>UserSettings: persist leaderboard columns
  TeamStats->>UserSettings: persist team statistics columns
  Leaderboard->>Leaderboard: sort and render selected cells
  TeamStats->>TeamStats: aggregate and render selected cells

Loading

Possibly related PRs

• openfrontio/OpenFrontIO#4379: Updates nearby leaderboard sorting logic for troop-related values.

Suggested labels: Translation

Suggested reviewers: evanpelle

Poem

Columns bloom beneath the gear,
Rows rearrange, crisp and clear.
Gold and troops now choose their place,
Teams sum up with steady grace.
One checkbox stays, the table sings—
Settings save the chosen things.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	It clearly summarizes the main change: configurable leaderboard and team stats columns.
Description check	✅ Passed	It matches the PR's UI and settings changes for configurable columns and tests.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70da3432d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".