Skip to content

mls (v5.8)#4656

Merged
evanpelle merged 2 commits into
openfrontio:mainfrom
Aotumuri:mls-5-8
Jul 21, 2026
Merged

mls (v5.8)#4656
evanpelle merged 2 commits into
openfrontio:mainfrom
Aotumuri:mls-5-8

Conversation

@Aotumuri

Copy link
Copy Markdown
Member

Description:

Version identifier within MLS: v5.8

[Changed languages]

  • bg
  • cs
  • da
  • fa
  • fr
  • hu
  • ja
  • ru
  • uk

[Change volume]

  • Changed languages: 9
  • Changed files: 9
  • Changed lines: 23690
  • metadata.json: unchanged

Final reviewer: meow

This PR was generated by the PR sender tool, then checked and submitted by the final reviewer.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e3bd4ea-abe7-4925-9425-bddd0c8c3368

📥 Commits

Reviewing files that changed from the base of the PR and between d0c0d66 and 6807035.

📒 Files selected for processing (1)
  • resources/lang/hu.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • resources/lang/hu.json

Walkthrough

This PR expands and refreshes Bulgarian, Czech, Danish, Persian, French, Hungarian, Japanese, Russian, and Ukrainian localization catalogs across account, clan, gameplay, maps, lobbies, stores, settings, and end-game UI.

Changes

Localization catalog refresh

Layer / File(s) Summary
Core locale and account/clan catalogs
resources/lang/*.json
Locale metadata and translations for account linking, clan management, chat, shared labels, events, and control-panel messages are expanded.
Gameplay, help, and graphics UI
resources/lang/*.json
Game information, event notifications, graphics settings, help text, unit terminology, and control descriptions are added or revised.
Navigation, maps, and matchmaking
resources/lang/*.json
Navigation, leaderboards, map names and categories, favorites, search, matchmaking, and discovery strings are expanded.
Lobby, store, and settings flows
resources/lang/*.json
Lobby options, subscriptions, territory patterns, troubleshooting, user settings, username validation, and win-dialog text are updated.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

Suggested reviewers: evanpelle

Poem

Nine tongues bloom across the screen,
With maps and menus joining in.
Clans, stores, and settings shine,
New phrases follow every line.
From lobby start to victory,
Local words guide the journey.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title only names the version and does not say what changed, so it is too generic. Use a short title that names the main change, such as the updated MLS translation set for v5.8.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description matches the PR content by listing the updated languages and version details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Aotumuri Aotumuri added the Translation Addition or modification of a language to the translations. label Jul 21, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/lang/bg.json`:
- Line 311: Correct the Bulgarian translation value for the stats_expand key
from “Покащи” to “Покажи”, preserving the existing key and JSON structure.

In `@resources/lang/cs.json`:
- Line 446: Correct the Czech verb typo in the request_alliance translation
value, changing “žáda” to “žádá” while preserving the {name} placeholder and
surrounding punctuation.

In `@resources/lang/da.json`:
- Line 1365: Update the build_atom_bomb translation value from “Byg Atombomb” to
“Byg Atombombe” in the Danish locale, matching the established label wording
elsewhere in the file.

In `@resources/lang/fa.json`:
- Around line 579-580: Correct the Persian text values for nuke_color_desc and
nuke_color_label so each uses the clean word "رنگ"; remove the
duplicated/garbled prefix and stray English “tint” from the description, and
remove the embedded zero-width character from the label.

In `@resources/lang/hu.json`:
- Line 954: Correct the Hungarian “twolakes” translation value from “Ké tTó” to
“Két Tó” in the language resource.
- Line 21: Update the google_alt translation value in hu.json to remove its
leading newline escape, leaving the plain “Google” label consistent with other
locales.

In `@resources/lang/ru.json`:
- Line 279: Update the Russian locale entry requested_on to use natural Russian
wording and wrap the tag placeholder in square brackets, matching the bracketed
format used by other locales.

In `@resources/lang/uk.json`:
- Around line 1481-1482: Update the Ukrainian localization entries too_long and
too_short to include the missing verb, using wording equivalent to “повинно
містити не більше ніж {max} символів” and “повинно містити не менше ніж {min}
символів.”
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2ffb0a5-b8b2-40d1-9018-df8c86159007

📥 Commits

Reviewing files that changed from the base of the PR and between da2e091 and d0c0d66.

📒 Files selected for processing (9)
  • resources/lang/bg.json
  • resources/lang/cs.json
  • resources/lang/da.json
  • resources/lang/fa.json
  • resources/lang/fr.json
  • resources/lang/hu.json
  • resources/lang/ja.json
  • resources/lang/ru.json
  • resources/lang/uk.json

Comment thread resources/lang/bg.json
Comment thread resources/lang/cs.json
Comment thread resources/lang/da.json
Comment thread resources/lang/fa.json
Comment thread resources/lang/hu.json Outdated
Comment thread resources/lang/hu.json
Comment thread resources/lang/ru.json
Comment thread resources/lang/uk.json
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jul 21, 2026
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Aotumuri Aotumuri added this to the v33 milestone Jul 21, 2026
@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Jul 21, 2026
@evanpelle
evanpelle merged commit 6734f76 into openfrontio:main Jul 21, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Translation Addition or modification of a language to the translations.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants