Skip to content

perf(store): fix packs tab stutter (animated drop-shadow filters + per-tile backdrop blur) #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpelle merged 1 commit into from
Aug 1, 2026
+16 −15
Merged

perf(store): fix packs tab stutter (animated drop-shadow filters + per-tile backdrop blur) #4821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/client/components/CosmeticContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ export class CosmeticContainer extends LitElement {
this.style.position = "relative";
this.style.background = `linear-gradient(to top, ${cfg.gradient} 0%, rgba(15,15,20,0.85) 100%)`;
this.style.border = `1px solid ${this.selected ? cfg.glow : cfg.border}`;
this.style.backdropFilter = "blur(8px)";
// No per-tile backdrop-filter: the tile gradient is ~85% opaque over the
// modal's already-blurred shell, so the blur is invisible — but dozens of
// blur surfaces made every animated frame in the store expensive.
this.style.borderRadius = "0.75rem";
this.style.transition =
"border-color 0.2s, background 0.2s, transform 0.2s cubic-bezier(0.34, 1.56, 0.64, 1), box-shadow 0.2s";
Expand Down
27 changes: 13 additions & 14 deletions src/client/components/PlutoniumIcon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,19 @@ const STYLE_ID = "plutonium-icon-styles";
if (!document.getElementById(STYLE_ID)) {
const style = document.createElement("style");
style.id = STYLE_ID;
// Only compositor-animatable properties (transform/opacity) may appear in
// these keyframes: animating filter/drop-shadow here re-rasterizes every
// icon each frame and forces the store's backdrop-blur surfaces to redraw,
// which stutters the whole packs menu (see #4816 follow-up).
style.textContent = `
@keyframes plutonium-pulse {
0% { filter: drop-shadow(0 0 4px rgba(34,197,94,0.6)) drop-shadow(0 0 8px rgba(34,197,94,0.3)); scale: 1; }
50% { filter: drop-shadow(0 0 10px rgba(34,197,94,0.9)) drop-shadow(0 0 20px rgba(34,197,94,0.5)) drop-shadow(0 0 30px rgba(34,197,94,0.2)); scale: 1.04; }
100% { filter: drop-shadow(0 0 4px rgba(34,197,94,0.6)) drop-shadow(0 0 8px rgba(34,197,94,0.3)); scale: 1; }
0%, 100% { opacity: 0.45; transform: scale(1); }
50% { opacity: 1; transform: scale(1.12); }
}
@keyframes plutonium-rotate {
0% { transform: rotate(0deg); }
100% { transform: rotate(360deg); }
}
@keyframes plutonium-jiggle {
0%, 100% { translate: 0 0; }
25% { translate: -0.4px 0.3px; }
50% { translate: 0.3px -0.4px; }
75% { translate: -0.3px -0.3px; }
}
`;
document.head.appendChild(style);
}
Expand All @@ -38,15 +35,17 @@ export class PlutoniumIcon extends LitElement {
render() {
return html`
<div
class="inline-flex items-center justify-center"
style="width:${this.size}px; height:${this
.size}px; animation: plutonium-pulse 2s ease-in-out infinite, plutonium-jiggle 0.15s linear infinite;"
class="relative inline-flex items-center justify-center"
style="width:${this.size}px; height:${this.size}px;"
>
<div
style="position:absolute; inset:-25%; pointer-events:none; background:radial-gradient(circle, rgba(34,197,94,0.5) 0%, rgba(34,197,94,0.22) 40%, transparent 68%); animation: plutonium-pulse 2s ease-in-out infinite; will-change: transform, opacity;"
></div>
<img
src=${assetUrl("images/PlutoniumIcon.svg")}
alt="Plutonium"
style="width:${this.size}px; height:${this
.size}px; animation: plutonium-rotate 7s linear infinite;"
style="position:relative; width:${this.size}px; height:${this
.size}px; filter: drop-shadow(0 0 4px rgba(34,197,94,0.6)); animation: plutonium-rotate 7s linear infinite; will-change: transform;"
draggable="false"
/>
</div>
Expand Down
Loading