feat(store): group skins/flags/crowns under a Cosmetics tab, add Merch tab - #4822
Merged
Conversation
…h tab The store's top-level tab bar was getting crowded. Skins, Flags, and Crowns are now grouped under a single Cosmetics tab with a sub-tab bar (styled like the effects grid's internal tabs). Old deep links using tab=patterns|flags|crowns are mapped onto the new tab so they still land on the right grid. Also adds a Merch tab: a short blurb and a Visit Store button linking to merch.openfront.io in a new tab. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
WalkthroughThe store modal groups patterns, flags, and crowns under a Cosmetics tab. It adds a Merch tab with translated promotional content and an external store link. ChangesStore tab restructuring
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant StoreModal
participant ExternalMerchandiseStore
User->>StoreModal: Select cosmetics or a cosmetics sub-tab
StoreModal->>StoreModal: Render the selected cosmetics panel
User->>StoreModal: Select merch
StoreModal->>ExternalMerchandiseStore: Open the merchandise store link
Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nothing links to tab=patterns|flags|crowns; unknown tabs already fall back to the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target="_blank" rel="noopener noreferrer").Old
tab=patterns|flags|crownsdeep links aren't specially handled — nothing links to them, and unknown tabs already fall back to the default (Packs).Test plan
npx tsc --noEmit, ESLint, Prettier all cleanstore.cosmetics,store.merch,store.merch_blurb,store.merch_visit_storekeys in en.json)🤖 Generated with Claude Code