Skip to content

Complete issues.#33

Open
shierru wants to merge 6 commits into
openmultiplayer:masterfrom
shierru:fix-issues
Open

Complete issues.#33
shierru wants to merge 6 commits into
openmultiplayer:masterfrom
shierru:fix-issues

Conversation

@shierru

@shierru shierru commented Jan 11, 2024

Copy link
Copy Markdown

Complete issues

Details

The GetPlayerAnimationFlags function is a duplicate of the GetPlayerAnimFlags function and I'm thinking about whether it should be labelled as such:

native GetPlayerAnimationFlags(playerid) = GetPlayerAnimFlags;

Or should it not be done?

It's not done at the moment.

Additionally:

@shierru

shierru commented Jan 11, 2024

Copy link
Copy Markdown
Author

I changed the parameter name of the function:
native bool:TogglePlayerWidescreen(playerid, bool:wide) => native bool:TogglePlayerWidescreen(playerid, bool:enable)

Since the feature was added quite recently, I doubt that it will cause any serious problems for users.

@Y-Less

Y-Less commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

Changing parameter names in natives doesn't make any difference. Annoyingly it does in forward for some weird reason, but that doesn't apply here and it just a side note.

I also wondering if GetPlayerAnimationFlags should return a tag/enum of valid values.

@adib-yg

adib-yg commented Feb 8, 2024

Copy link
Copy Markdown
Member

There's a doc for GetPlayerAnimationFlags
Can these definitions be added to stdlib?

#define ANIM_FREEZE_FLAG   0b0000000000000100
#define ANIM_LOCK_X_FLAG   0b0010000000000
#define ANIM_LOCK_Y_FLAG   0b0001000000000
#define ANIM_LOOP_FLAG     0b0000100000000

@Y-Less

Y-Less commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

Probably just use hex like most other numbers, but otherwise yes that's what I meant by the enum comment.

@shierru

shierru commented Apr 5, 2024

Copy link
Copy Markdown
Author

I added a return tag for GetPlayerAnimationFlags. But I'm still not sure if I did it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants