Skip to content

[release-4.22] OCPBUGS-87933, OCPBUGS-87985: Bump protobufjs and shell-quote#16619

Open
matzew wants to merge 3 commits into
openshift:release-4.22from
matzew:cherry-pick-16586-to-release-4.22
Open

[release-4.22] OCPBUGS-87933, OCPBUGS-87985: Bump protobufjs and shell-quote#16619
matzew wants to merge 3 commits into
openshift:release-4.22from
matzew:cherry-pick-16586-to-release-4.22

Conversation

@matzew

@matzew matzew commented Jun 15, 2026

Copy link
Copy Markdown
Member

Updated version of #16603

(which was/is an automated cherry-pick of #16586)

matzew added 3 commits June 15, 2026 14:44
@matzew
OCPBUGS-87933: Bump protobufjs to 7.5.6 to fix CVE-2026-44293
e517874 
Add yarn resolutions for protobufjs (7.5.6) and shell-quote (^1.8.4)
to address arbitrary code execution via unsafe expression generation
from crafted protobuf descriptors.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Run yarn dedupe to resolve duplicate @protobufjs/inquire
4e06651 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Bump protobufjs to 7.5.8 and pin shell-quote to 1.8.4
7599baf 
Address CodeRabbit review feedback:
- protobufjs 7.5.6 still affected by CVE-2026-45740, bump to 7.5.8
- Pin shell-quote to exact version 1.8.4 (drop caret range)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@matzew: This pull request references Jira Issue OCPBUGS-87933, which is invalid:

  • expected dependent Jira Issue OCPBUGS-87930 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-87985, which is invalid:

  • expected dependent Jira Issue OCPBUGS-87982 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Updated version of #16603

(which was/is an automated cherry-pick of #16586)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@matzew matzew mentioned this pull request Jun 15, 2026
Closed
@openshift-ci openshift-ci Bot requested review from Leo6Leo and cajieh June 15, 2026 12:47
@matzew

matzew commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@matzew: This pull request references Jira Issue OCPBUGS-87933, which is invalid:

  • expected dependent Jira Issue OCPBUGS-87930 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-87985, which is invalid:

  • expected dependent Jira Issue OCPBUGS-87982 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@matzew

matzew commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@matzew: This pull request references Jira Issue OCPBUGS-87933, which is invalid:

  • expected Jira Issue OCPBUGS-87933 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-87985, which is invalid:

  • expected dependent Jira Issue OCPBUGS-87982 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@matzew

matzew commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@matzew: This pull request references Jira Issue OCPBUGS-87933, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-87930 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-87930 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

This pull request references Jira Issue OCPBUGS-87985, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-87982 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-87982 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@matzew: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fsgreco

fsgreco commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@fsgreco: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2026
jhadvig
jhadvig approved these changes Jun 16, 2026
View reviewed changes

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsgreco, jhadvig, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@cajieh cajieh Awaiting requested review from cajieh

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@fsgreco fsgreco

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matzew @openshift-ci-robot @fsgreco @jhadvig