Skip to content

NO-JIRA: Small updates post #16585 changes#16624

Open
vojtechszocs wants to merge 1 commit into
openshift:mainfrom
vojtechszocs:cleanup-post-16585
Open

NO-JIRA: Small updates post #16585 changes#16624
vojtechszocs wants to merge 1 commit into
openshift:mainfrom
vojtechszocs:cleanup-post-16585

Conversation

@vojtechszocs

@vojtechszocs vojtechszocs commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Analysis / Root cause

Small updates post #16585 changes.

Also removed top level node_modules/.yarn-integrity and yarn.lock files.

Test cases

These changes should have no impact on Console or plugin SDK builds.

Summary by CodeRabbit

  • New Features

    • Expanded default module import skip list to include additional internal module patterns, reducing build warnings.
  • Documentation

    • Updated release notes documenting the skipImportPrefixes configuration option for controlling module import behavior.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

defaultDynamicModuleImportSkipPrefixes in DynamicModuleImportPlugin.ts is extended with two PatternFly internal subpaths (Tooltip/ and Popover/). The JSDoc for ConsoleRemotePluginOptions.skipImportPrefixes is refined to clarify append behavior. Both changelogs are updated to reflect these and prior prerelease.3 items.

Changes

Default skip prefix extension and documentation

Layer / File(s) Summary
Extend default skip prefixes and refine JSDoc
frontend/packages/console-dynamic-plugin-sdk/src/webpack/DynamicModuleImportPlugin.ts, frontend/packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts
defaultDynamicModuleImportSkipPrefixes gains two PatternFly ESM subpath entries (Tooltip/ and Popover/). The skipImportPrefixes JSDoc is updated to describe append-to-default behavior and remove the @see reference.
Changelog updates
frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-webpack.md, frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md
Webpack changelog replaces the DynamicModuleImportLoaderOptions-scoped skipImportPrefixes bullet with a ConsoleRemotePlugin-scoped description under 4.23.0-prerelease.3. Core changelog moves the @openshift/api-types bullet into 4.23.0-prerelease.3 and applies minor wording to the prerelease.2 react-topology entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/console#16585: Introduced and wired the skipImportPrefixes customization feature that this PR extends with additional default prefixes and updated documentation.

Suggested labels

component/sdk

Suggested reviewers

  • fsgreco
  • jhadvig
🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and missing several required sections from the template. Add missing sections: Solution description, Screenshots/screen recording, Test setup, Browser conformance checkboxes, and Reviewers/assignees tags to comply with repository template requirements.
Title check ❓ Inconclusive The title references PR #16585 but provides minimal detail about the actual changes, making it vague and context-dependent for understanding the primary modifications. Consider a more descriptive title like 'Update dynamic plugin SDK documentation and skip prefixes' to clearly convey the main changes without requiring external PR context.
✅ Passed checks (13 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR contains no Ginkgo test files. It only modifies frontend TypeScript source files and markdown changelogs, making the check not applicable.
Test Structure And Quality ✅ Passed This PR contains no Ginkgo test code. It only modifies 2 changelog files and 2 TypeScript source files (webpack plugins), so the test structure quality check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to changelog documentation and webpack build infrastructure code (ConsoleRemotePlugin.ts and DynamicModuleImportPlugin.ts), none of whi...
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to changelog updates and TypeScript source code modifications (documentation and configuration), not e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only SDK library code and changelog files with no deployment manifests, operator controllers, or scheduling constraints. The changes are build-time webpack plugin updates and docum...
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check is inapplicable to this PR. The PR contains only TypeScript/JavaScript and Markdown files for a console plugin SDK; it has no Go code and therefore no OTE test bina...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR contains no Ginkgo e2e tests. Changes are limited to CHANGELOG documentation and TypeScript source documentation/configuration updates in the console-dynamic-plugin-sdk package.
No-Weak-Crypto ✅ Passed No weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons detected. Changes involve only webpack plugin configuration and changelog documentation.
Container-Privileges ✅ Passed PR modifies only changelog and TypeScript source files—no container/Kubernetes manifests present; no privileged settings found.
No-Sensitive-Data-In-Logs ✅ Passed No new logging that exposes sensitive data (passwords, tokens, API keys, PII, session IDs, hostnames, customer data) found. Changes only add import path prefixes to a skip list and update documenta...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from TheRealJon and rhamilto June 15, 2026 18:21
@openshift-ci openshift-ci Bot added the component/sdk Related to console-plugin-sdk label Jun 15, 2026
@vojtechszocs vojtechszocs changed the title Small updates post #16585 changes NO-JIRA: Small updates post #16585 changes Jun 15, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@vojtechszocs: This pull request explicitly references no jira issue.

Details

In response to this:

Analysis / Root cause

Small updates post #16585 changes.

Test cases

These changes should have no impact on Console or plugin SDK builds.

Summary by CodeRabbit

  • New Features

  • Expanded default module import skip list to include additional internal module patterns, reducing build warnings.

  • Documentation

  • Updated release notes documenting the skipImportPrefixes configuration option for controlling module import behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vojtechszocs

Copy link
Copy Markdown
Contributor Author

/label px-approved

@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Jun 15, 2026

@TheRealJon TheRealJon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/verified by @TheRealJon

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@TheRealJon: This PR has been marked as verified by @TheRealJon.

Details

In response to this:

/lgtm
/verified by @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants