fix: Merge extra on update instead of replacing#787
Open
mashawes wants to merge 2 commits into
Open
Conversation
gtema
requested changes
Jun 12, 2026
gtema
left a comment
Collaborator
There was a problem hiding this comment.
The change on it's own is clean, there is however one critical issue: provider sends one value for update (which is also logged in traces), but drivers persist a different value. It also opens doors for situations that for 1 provider one drivers merges the data, while the second one misses it and overwrites the data. The same is valid across providers.
It must be responsibility of the provider to prepare the data, while the backend driver is only responsible for persistence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes update operations so the extra JSON field is merged with the existing value instead of being fully replaced, matching Python Keystone behavior
Closes #777
Note: this contribution was developed with AI assistance.