Fix non-mediapipe build#4393
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression affecting non-MediaPipe builds by ensuring MediaPipe/TensorFlow-dependent headers are only included when MEDIAPIPE_DISABLE == 0, and by adjusting Bazel test dependencies accordingly (regression traced to PR #4349, Ticket: CVS-191156).
Changes:
- Guard MediaPipe/TensorFlow-related includes in stress-test utilities behind
#if (MEDIAPIPE_DISABLE == 0). - Guard the
kfs_graph_executor_impl.hppinclude inensemble_config_change_stress.cppbehind the same MediaPipe flag. - Add MediaPipe-related deps to the
ovms_testBazel target for MediaPipe-enabled builds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/test/stress_test_utils.hpp |
Moves MediaPipe/TensorFlow includes under a MediaPipe-only preprocessor guard to avoid non-MediaPipe build failures. |
src/test/ensemble_config_change_stress.cpp |
Wraps MediaPipe-dependent include behind MEDIAPIPE_DISABLE to keep the file buildable when MediaPipe is disabled. |
src/BUILD |
Updates ovms_test dependencies for MediaPipe-enabled builds to include MediaPipe executor/utils and TF type utils. |
mzegla
approved these changes
Jul 22, 2026
dkalinowski
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced with:
#4349
Include of kfs_graph_executor_impl.hpp in src/test/ensemble_config_change_stress.cpp was not done behind ifdef.
Ticket:CVS-191156