update default target device in tests#4396
Merged
Merged
Conversation
pgladkows
force-pushed
the
fix-default-target-device
branch
3 times, most recently
from
July 23, 2026 14:31
30c5c05 to
7e37063
Compare
pgladkows
force-pushed
the
fix-default-target-device
branch
from
July 23, 2026 14:39
7e37063 to
a84bb10
Compare
pgladkows
marked this pull request as ready for review
July 23, 2026 14:51
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates functional test helpers to consistently default the target device to CPU when no explicit device is provided, reducing reliance on implicit defaults in generated OVMS commands and MediaPipe graph snippets.
Changes:
- Default OVMS command
target_devicetoCPUwhenparameters.target_deviceis unset. - Emit
device/target_devicefields in generated MediaPipe calculator node content usingCPUas the fallback. - Ensure model config generation always includes
target_device, defaulting toCPUwhen unset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/functional/object_model/ovms_command.py | Defaults target_device to CPU when building the OVMS command. |
| tests/functional/object_model/mediapipe_calculators.py | Defaults MediaPipe node device/target_device fields to CPU when unspecified. |
| tests/functional/models/models.py | Always includes target_device in generated model config, defaulting to CPU. |
| batchsize=batch_size if use_parameter else None, | ||
| nireq=parameters.nireq if use_parameter else None, | ||
| target_device=parameters.target_device if use_parameter else None, | ||
| target_device=(parameters.target_device or TargetDevice.CPU) if use_parameter else None, |
pgladkows
force-pushed
the
fix-default-target-device
branch
from
July 23, 2026 15:10
f78e84e to
0678a01
Compare
dkalinowski
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
https://jira.devtools.intel.com/browse/CVS-191325
Add default target device (CPU) to tests.
🧪 Checklist
``