Skip to content

[CI] Changing windows artifacts name | pushing signed files to share#4397

Open
przepeck wants to merge 9 commits into
mainfrom
przepeck/windows_ci_package_name_fix
Open

[CI] Changing windows artifacts name | pushing signed files to share#4397
przepeck wants to merge 9 commits into
mainfrom
przepeck/windows_ci_package_name_fix

Conversation

@przepeck

Copy link
Copy Markdown
Collaborator

🛠 Summary

CVS-187402
Removing commit sha from package name to be consistent for automate.
Fixed pushing signed files to the share.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

@przepeck
przepeck requested review from Copilot and pgladkows July 23, 2026 13:55
@przepeck przepeck changed the title Changing windows artifacts name | pushing signed files to share [CI] Changing windows artifacts name | pushing signed files to share Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows Jenkins pipeline to make promoted artifact naming consistent (removing the commit SHA from the ZIP name) and to improve the promotion flow for signed outputs copied to the network share.

Changes:

  • Persist the build timestamp as env.BUILDSTAMP and use it when promoting artifacts.
  • Wrap BDBA and signing stages in catchError so failures don’t hard-fail the whole build (build becomes UNSTABLE while the stage is FAILURE).
  • Add a dedicated “Promote package” stage that copies either the signed ZIP (if present) or falls back to the unsigned ZIP, and publishes it to the share under both a timestamped folder and latest.
Comments suppressed due to low confidence (1)

ci/build_test_release.groovy:168

  • The signed package’s .sha256 file is only copied into the latest folder, but not into the timestamped ${destPath}\\${env.BUILDSTAMP} folder (even though the package itself is copied to both). This makes the archived buildstamp directory incomplete and breaks integrity verification for non-latest builds.
                        if (shaFile != "" && fileExists("${env.WORKSPACE}\\dist\\windows\\${shaFile}")) {
                            status = bat(returnStatus:true, script: "copy /Y \"${env.WORKSPACE}\\dist\\windows\\${shaFile}\" \"${latestPath}\\${packageName}.sha256\"")
                            if (status != 0) {

Comment thread ci/build_test_release.groovy
Comment thread ci/build_test_release.groovy
@przepeck
przepeck requested a review from dtrawins July 23, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants