Add a case for incompatible Perl package versions in check_modules.pl.#3013
Merged
somiaj merged 1 commit intoJun 10, 2026
Merged
Conversation
Any package can have an `incompatibleVersions` flag whose value should be a reference to an array of version strings. If the version on the system of a package is one of these versions, then `check_modules.pl` will warn about it. `Mojolicious` now has this set for versions 9.43, 9.44, 9.45, and 9.46. Also remove unneeded quotes on left operands of a fat comma and hash keys. I missed these when they were added in openwebwork#2893. I left the quotes on the single word package names which also don't need them, but this is consistent with the other package names that do.
Alex-Jordan
approved these changes
Jun 10, 2026
Alex-Jordan
left a comment
Alex-Jordan
left a comment
Contributor
There was a problem hiding this comment.
I went to Mojolicious 9.45 and this caught it. Back to 9.42 and I passed the check.
somiaj
approved these changes
Jun 10, 2026
somiaj
left a comment
somiaj
left a comment
Contributor
There was a problem hiding this comment.
I am not able to test if it catches bad versions of mojolicious, but the script works just fine for me with a valid version.
Contributor
|
Going to accept @Alex-Jordan that it correctly catches the bad versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any package can have an
incompatibleVersionsflag whose value should be a reference to an array of version strings. If the version on the system of a package is one of these versions, thencheck_modules.plwill warn about it.Mojoliciousnow has this set for versions 9.43, 9.44, 9.45, and 9.46.Also remove unneeded quotes on left operands of a fat comma and hash keys. I missed these when they were added in #2893. I left the quotes on the single word package names which also don't need them, but this is consistent with the other package names that do.
Note that the primary changes (the ones not just removing unneeded quotes) are lines 682 - 690, and the addition of the key for the
Mojoliciouspackage on line 354.