[AI-FSSDK] [FSSDK-12834] Replace non-numeric holdout placeholder IDs in event-construction tests#646
Merged
Conversation
…in event-construction tests
|
Coverage is 93.849% — ai/jaeopt/FSSDK-12834-holdout-event-p2 into master. No base build found for |
…mpaign_id contract
…y non-empty string
Drop FSSDK-12813 / FSSDK-12834 references from production and test code (ticket IDs belong in commit messages and PR titles, not source). Tighten the verbose multi-line docstrings down to one short line each or remove them where the code is self-explanatory. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per FR-011 / SC-007 of the decision-event ID normalization spec, every pre-existing test that constructs an event payload must use valid decimal-digit string IDs. Non-numeric holdout placeholders implicitly relied on the pre-fix pass-through behavior and would either silently change their on-the-wire output after the normalization landed or assert the wrong thing.
Changes
id, variationid, and trafficAllocationentityIdplaceholders with numeric-string IDs across all holdout-related test fixtures whose tests dispatch impression events (BatchEventBuilder, DecisionListener, decide-API, decide-reasons, local-holdout suites).variation_id(matching the post-fix happy-path normalization).BatchEventBuilderTests_HoldoutIds.swiftand the no-dispatchDecisionServiceTests_Holdouts.swiftfixtures unchanged — the former intentionally exercises the fallback contract, the latter never reaches the event builder.Jira Ticket
FSSDK-12834