Add unit tests for osism/utils/rabbitmq.py

[berendt]

Closes #2232

Adds tests/unit/utils/test_rabbitmq.py covering both functions in
osism/utils/rabbitmq.py. Test-only change; no production code is touched.

What is covered

get_rabbitmq_node_addresses()

• Inventory & host discovery: two hosts processed in alphabetical
  order (happy path returning [("10.0.0.5","host1"),("10.0.0.6","host2")]);
  empty rabbitmq group → None; first subprocess.check_output raising
  CalledProcessError; invalid JSON from the group listing
  (JSONDecodeError); outer generic exception.
• Per-host resolution: cache miss skips the host and continues to the
  next; missing internal_interface; literal interface name used
  directly; Jinja2 template resolved via dotted-path traversal of the
  facts; template resolving to a non-string (None / dict / int);
  traversal hitting a non-dict mid-walk; interface-name normalization
  (eth0.100 → ansible_eth0_100, eth-0 → ansible_eth_0); missing
  normalized interface key; interface without ipv4; ipv4 without an
  address.
• Aggregate: all hosts skipped → None; at least one address → the
  list is returned with no error logged.

load_rabbitmq_password() — missing file; empty / invalid / non-dict
secrets; missing rabbitmq_password key; whitespace stripping; int
coercion; loader raising.

Plus a check that the RABBITMQ_USER module constant is "openstack".

Notes for the reviewer

• Redis mocking deviates from the issue's hint. The issue suggested
  mocker.patch("osism.utils.rabbitmq.utils.redis", ...), but that target
  does not resolve: redis is a lazy __getattr__ attribute on the
  osism.utils package, and the function reads it via a function-local
  from osism import utils, so the rabbitmq module never gains a utils
  global (AttributeError: module 'osism.utils.rabbitmq' has no attribute 'utils'). Instead the cached attribute is seeded on the package
  namespace with mocker.patch.dict(osism.utils.__dict__, {"redis": ...}),
  which also bypasses the lazy initializer that would otherwise open a real
  Redis connection. Reading the cache key the function builds is asserted in
  the happy-path test.
• load_yaml_file and os.path.exists are patched at the call site, as the
  issue suggests.
• Tests follow the existing mocker + loguru_logs conventions
  (see tests/unit/utils/test_init_connections.py).

Verification

• pytest tests/unit/utils/test_rabbitmq.py --cov=osism.utils.rabbitmq
  → 28 passed, 100% line coverage (run in the CI-equivalent
  environment where ansible-core is absent and tests/conftest.py
  installs its ansible stubs).
• black --check, flake8, mypy clean on the new file.

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• The test module is quite long and dense; consider splitting it into smaller logical sections (e.g., separate files or pytest classes for get_rabbitmq_node_addresses and load_rabbitmq_password) or introducing shared fixtures to reduce repetition and improve readability.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test module is quite long and dense; consider splitting it into smaller logical sections (e.g., separate files or pytest classes for `get_rabbitmq_node_addresses` and `load_rabbitmq_password`) or introducing shared fixtures to reduce repetition and improve readability.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}