AO3-5984 Add max-min limits to int range searches#5935
Open
techlingyi wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5984
Purpose
Adds an MAX_SEARCH_INT_RANGE: 2000000000 constant to config/config.yml and clamps all int-range searches (including
num,<num,>num, andnum1-num2) within the range 0 to MAX_SEARCH_INT_RANGE.Since int ranges are all handled by the same function, this does go beyond the ticket for word count to also affect searches on hits count, kudos count, etc., but these statistics are also stored in MySQL int columns and so should also have the same maximum search limit. (They currently experience the same 500 error that word count does with numbers that are too large.)
Testing Instructions
(already touched on in the Jira issue but for the sake of completeness)
Credit
Ling-Yi (any pronouns)