fix: correct broken xrefs in useful_pages (#1541)#1545
Merged
Conversation
phil-davis
approved these changes
Jun 16, 2026
The links in useful_pages.adoc carried a 'server:' component prefix
without a version coordinate:
xref:server:admin_manual:installation/installing_with_docker.adoc[...]
Per Antora's resolution rules, a component-qualified xref without a
version resolves against the latest non-prerelease version of that
component. Since 'next' is flagged prerelease in antora.yml, in the
multi-version production build these xrefs resolved against the current
release rather than next.
installing_with_docker.adoc was newly added/renamed in next (from
installation/docker/index.adoc), so the target did not exist in the
release version. Antora could not resolve it and emitted a self-anchor
fallback, producing the broken link reported in the issue:
useful_pages.html#server:admin_manual:installation/installing_with_docker.adoc
useful_pages.adoc itself lives in the server component, so dropping the
'server:' prefix makes these same-component xrefs resolve against the
current page's version (where every target exists). This matches how
all other references to these pages are written across the repo.
Note: the previous {latest-server-version}@server: form could not be
restored because latest-server-version is defined unquoted in
antora.yml and parses as a YAML object, rendering as [object Object].
Fixes #1541
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
33be40b to
83ba700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
useful_pages.htmlthe Installation with Docker link renders as a dead on-page anchor instead of a real link:Fixes #1541
Root cause
The four links in
useful_pages.adoccarried aserver:component prefix without a version coordinate:Per Antora's resolution rules, a component-qualified xref with no version resolves against the latest non-prerelease version of that component. Since
nextis flaggedprerelease: trueinantora.yml, in the multi-version production build (owncloud/docs) these xrefs resolved against the current release rather thannext.installing_with_docker.adocwas newly added/renamed innext(frominstallation/docker/index.adoc) in #1511, so the target did not exist in the release version. Antora could not resolve it and emitted a self-anchor fallback — exactly the broken URL reported in the issue.This is why the page builds clean locally: a local build only contains
next, so "latest" ==next, where the file exists.Fix
useful_pages.adocitself lives in theservercomponent, so dropping theserver:prefix makes these same-component xrefs resolve against the current page's version (where every target exists). This also matches how all other references to these pages are written across the repo.Verification
Local Antora build confirms all four links now render as proper anchors with no
[object Object]and no#server:admin_manualself-anchor fallback:installation/installing_with_docker.html✅ (the reported link)configuration/server/occ_command.html✅configuration/server/caching_configuration.html#small-organization-single-server-setup✅maintenance/upgrading/manual_upgrade.html✅Follow-up (out of scope)
The broken
latest-server-versionattribute ([object Object]from unquoted YAML inantora.yml) also leaks intopublic_link_shares.htmland thecollabora_secure_viewreferences. That's a separate defect worth its own fix.🤖 Generated with Claude Code