-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix composite node duplication placement #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| import { afterEach, beforeEach, describe, expect, test } from 'bun:test' | ||
| import { | ||
| type AnyNode, | ||
| type AnyNodeId, | ||
| LevelNode, | ||
| StairNode, | ||
| StairSegmentNode, | ||
| useScene, | ||
| } from '@pascal-app/core' | ||
| import { useViewer } from '@pascal-app/viewer' | ||
| import useInteractionScope, { getMovingNode } from '../store/use-interaction-scope' | ||
| import { duplicateStairSubtree } from './stair-duplication' | ||
|
|
||
| const LEVEL_ID = 'level_stair-duplicate' as AnyNodeId | ||
| const STAIR_ID = 'stair_original' as AnyNodeId | ||
| const SEGMENT_ID = 'sseg_original' as AnyNodeId | ||
|
|
||
| function seedStraightStair() { | ||
| const level = LevelNode.parse({ | ||
| id: LEVEL_ID, | ||
| type: 'level', | ||
| children: [STAIR_ID], | ||
| }) | ||
| const stair = StairNode.parse({ | ||
| id: STAIR_ID, | ||
| type: 'stair', | ||
| parentId: LEVEL_ID, | ||
| children: [SEGMENT_ID], | ||
| position: [2, 0, 3], | ||
| }) | ||
| const segment = StairSegmentNode.parse({ | ||
| id: SEGMENT_ID, | ||
| type: 'stair-segment', | ||
| parentId: STAIR_ID, | ||
| }) | ||
| useScene.setState({ | ||
| nodes: { | ||
| [LEVEL_ID]: level as AnyNode, | ||
| [STAIR_ID]: stair as AnyNode, | ||
| [SEGMENT_ID]: segment as AnyNode, | ||
| }, | ||
| rootNodeIds: [LEVEL_ID], | ||
| collections: {}, | ||
| dirtyNodes: new Set(), | ||
| } as never) | ||
| } | ||
|
|
||
| describe('duplicateStairSubtree', () => { | ||
| beforeEach(() => { | ||
| useInteractionScope.getState().end() | ||
| useViewer.getState().setSelection({ selectedIds: [STAIR_ID] }) | ||
| useScene.temporal.getState().clear() | ||
| useScene.temporal.getState().resume() | ||
| seedStraightStair() | ||
| }) | ||
|
|
||
| afterEach(() => { | ||
| useInteractionScope.getState().end() | ||
| useScene.temporal.getState().resume() | ||
| useViewer.getState().setSelection({ selectedIds: [] }) | ||
| }) | ||
|
|
||
| test('moves the exact fresh scene subtree and clears the original selection', () => { | ||
| const result = duplicateStairSubtree(STAIR_ID, { mode: 'move' }) | ||
| const nodes = useScene.getState().nodes | ||
| const draft = nodes[result.stair.id as AnyNodeId] | ||
|
|
||
| expect(result.stair.id).not.toBe(STAIR_ID) | ||
| expect(draft).toBe(result.stair) | ||
| expect(getMovingNode()?.id).toBe(result.stair.id) | ||
| expect(useViewer.getState().selection.selectedIds).toEqual([]) | ||
| expect((result.stair.metadata as Record<string, unknown>)?.isNew).toBe(true) | ||
| expect(result.stair.position).toEqual([3, 0, 4]) | ||
| expect(result.segmentIds).toHaveLength(1) | ||
| expect(result.segmentIds[0]).not.toBe(SEGMENT_ID) | ||
| expect(nodes[result.segmentIds[0] as AnyNodeId]?.parentId).toBe(result.stair.id) | ||
| expect(nodes[STAIR_ID]).toBeDefined() | ||
| expect(nodes[SEGMENT_ID]).toBeDefined() | ||
| expect(useScene.temporal.getState().isTracking).toBe(false) | ||
| }) | ||
|
|
||
| test('keeps childless curved stairs on the same real draft path', () => { | ||
| const curved = StairNode.parse({ | ||
| ...(useScene.getState().nodes[STAIR_ID] as AnyNode), | ||
| children: [], | ||
| stairType: 'curved', | ||
| }) | ||
| useScene.setState((state) => ({ | ||
| nodes: { | ||
| ...state.nodes, | ||
| [LEVEL_ID]: { ...state.nodes[LEVEL_ID], children: [STAIR_ID] } as AnyNode, | ||
| [STAIR_ID]: curved as AnyNode, | ||
| }, | ||
| })) | ||
|
|
||
| const result = duplicateStairSubtree(STAIR_ID, { mode: 'move', offset: [0, 0, 0] }) | ||
|
|
||
| expect(result.segmentIds).toEqual([]) | ||
| expect(useScene.getState().nodes[result.stair.id as AnyNodeId]).toBe(result.stair) | ||
| expect(getMovingNode()?.id).toBe(result.stair.id) | ||
| expect((result.stair.metadata as Record<string, unknown>)?.isNew).toBe(true) | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stair duplicate drops placement offset
Medium Severity
3D duplicate now routes stairs through
createFreshPlacementSubtreewith no position patch, but the removed menu path usedduplicateStairSubtree, which defaulted to a[1, 0, 1]offset. The draft is created at the source stair’s position, so it overlaps the original until the user moves it, unlike other positioned duplicates that get a small nudge.Additional Locations (1)
packages/editor/src/components/editor-2d/floorplan-registry-action-menu.tsx#L326-L330Reviewed by Cursor Bugbot for commit f1a14da. Configure here.