Skip to content

fix(OutlinedCalendarAltIcon): Replace OutlinedCalendarAltIcon#12463

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-outlined-calendar-alt-icon-with-rh-ui-calendar
Open

fix(OutlinedCalendarAltIcon): Replace OutlinedCalendarAltIcon#12463
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-outlined-calendar-alt-icon-with-rh-ui-calendar

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Replaced the calendar icon used in DatePicker and DateTimePicker components with an updated UI calendar icon.
  • Documentation
    • Updated the DateTimePicker demo to reflect the new calendar icon in examples and docs.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 29467de0-9d5a-4a2f-99db-a7f9473cd3d1

📥 Commits

Reviewing files that changed from the base of the PR and between 057ec2f and dd212a6.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • packages/react-core/src/components/DatePicker/DatePicker.tsx
  • packages/react-core/src/demos/DateTimePicker.md
  • packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/react-core/src/demos/DateTimePicker.md
  • packages/react-core/src/components/DatePicker/DatePicker.tsx
  • packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx

Walkthrough

Replaces OutlinedCalendarAltIcon with RhUiCalendarIcon in the DatePicker component, DateTimePicker example, and demo documentation (imports and Button icon prop).

Changes

Calendar icon replacement

Layer / File(s) Summary
Replace calendar icon in DatePicker components and demos
packages/react-core/src/components/DatePicker/DatePicker.tsx, packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx, packages/react-core/src/demos/DateTimePicker.md
Updated imports and Button icon prop usage from OutlinedCalendarAltIcon to RhUiCalendarIcon across the DatePicker component, DateTimePicker example, and demo markdown.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • kmcfaul
  • thatblindgeye
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title describes replacing OutlinedCalendarAltIcon but is incomplete—it doesn't specify the replacement icon (RhUiCalendarIcon) or clearly communicate the full scope of the change. Consider a more complete title like 'fix: Replace OutlinedCalendarAltIcon with RhUiCalendarIcon' to clearly indicate both what was replaced and what it was replaced with.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-outlined-calendar-alt-icon-with-rh-ui-calendar branch from b77b0b0 to 057ec2f Compare June 12, 2026 18:26
…UiCalendarIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-outlined-calendar-alt-icon-with-rh-ui-calendar branch from 057ec2f to dd212a6 Compare June 12, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants