Skip to content

fix(OutlinedClockIcon): Replace OutlinedClockIcon with RhUiClockIcon#12465

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-outlined-clock-icon-with-rh-ui-clock
Open

fix(OutlinedClockIcon): Replace OutlinedClockIcon with RhUiClockIcon#12465
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-outlined-clock-icon-with-rh-ui-clock

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated clock icon styling across TimePicker and DateTimePicker components for visual consistency.
    • Demo examples and documentation reflect the updated icon appearance.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e464c03-3ab5-4d19-9ee6-8220dc6f28dc

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528bb and 2e12821.

📒 Files selected for processing (3)
  • packages/react-core/src/components/TimePicker/TimePicker.tsx
  • packages/react-core/src/demos/DateTimePicker.md
  • packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx

Walkthrough

This PR replaces the OutlinedClockIcon with RhUiClockIcon across the TimePicker component implementation and its demo examples. The change affects the icon imports and prop assignments in both the core component and the demo documentation.

Changes

Clock icon replacement

Layer / File(s) Summary
TimePicker component icon update
packages/react-core/src/components/TimePicker/TimePicker.tsx
The TimePicker component import statement replaces OutlinedClockIcon with RhUiClockIcon, and the TextInput customIcon prop is updated to render the new icon.
Demo and documentation icon updates
packages/react-core/src/demos/examples/DateTimePicker/DateTimePicker.tsx, packages/react-core/src/demos/DateTimePicker.md
The DateTimePicker demo example and documentation are updated to import RhUiClockIcon instead of OutlinedClockIcon, and the MenuToggle icon prop is changed to use the new icon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • kmcfaul
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing OutlinedClockIcon with RhUiClockIcon across TimePicker, DateTimePicker demo, and related components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-outlined-clock-icon-with-rh-ui-clock branch from dbc6a91 to 2e12821 Compare June 12, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants