Skip to content

Fix spack images#35

Open
iole-bolognesi wants to merge 24 commits into
v4from
fix_spack_images
Open

Fix spack images#35
iole-bolognesi wants to merge 24 commits into
v4from
fix_spack_images

Conversation

@iole-bolognesi

@iole-bolognesi iole-bolognesi commented Jun 24, 2026

Copy link
Copy Markdown

Fixes issue #34

@iole-bolognesi
iole-bolognesi marked this pull request as ready for review June 26, 2026 06:34
Comment thread spack/2-spackbase/Dockerfile Outdated

@jmorice91 jmorice91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

Comment thread spack/3-baselibs/clang.lst Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile Outdated

@benoitmartin88 benoitmartin88 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are required.

Comment thread .github/workflows/debuntu_docker_images.yml Outdated
Comment thread .github/workflows/spack_docker_images.yml Outdated
Comment thread spack/2-spackbase/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment on lines +116 to +119
- $buildeps
- $libs
- $mpi
- $mpilibs

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the matrix ?

@iole-bolognesi iole-bolognesi Jul 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was causing an error (see the comment on line 122). I couldn't find a related issue in Spack, but removing the matrix seems to fix the problem. I am still a bit confused about this error, maybe someone with more experience in Spack can investigate it further.

Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/4-mini/Dockerfile
Comment thread spack/5-all/Dockerfile
Comment thread spack/6-finalize/Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spack images failing with latest version of spack

4 participants