Fix spack images#35
Open
iole-bolognesi wants to merge 24 commits into
Open
Conversation
iole-bolognesi
marked this pull request as ready for review
June 26, 2026 06:34
jmorice91
reviewed
Jun 29, 2026
jmorice91
reviewed
Jun 29, 2026
JAuriac
reviewed
Jun 30, 2026
…to COMPILER_SPECIFIC_VARIANTS
…ckage only for the latest version of spack
benoitmartin88
requested changes
Jul 16, 2026
benoitmartin88
left a comment
Member
There was a problem hiding this comment.
A few changes are required.
Comment on lines
+116
to
+119
| - $buildeps | ||
| - $libs | ||
| - $mpi | ||
| - $mpilibs |
Author
There was a problem hiding this comment.
It was causing an error (see the comment on line 122). I couldn't find a related issue in Spack, but removing the matrix seems to fix the problem. I am still a bit confused about this error, maybe someone with more experience in Spack can investigate it further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #34