Skip to content

Narrow Join::join() $columns parameter to array|string #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrsson merged 1 commit into from
Jul 8, 2026
+2 −2
Merged

Narrow Join::join() $columns parameter to array|string #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Sql/Join.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public function getJoins(): array
* @param array|string|TableIdentifier $name A table name on which to join, or a single
* element associative array, of the form alias => table, or TableIdentifier instance
* @param string|Predicate\Expression $on A specification describing the fields to join on.
* @param int|string|int[]|string[] $columns A single column name, an array
* @param string|string[] $columns A single column name, an array
* of column names, or (a) specification(s) such as SQL_STAR representing
* the columns to join.
* @param string $type The JOIN type to use; see the JOIN_* constants.
Expand All @@ -121,7 +121,7 @@ public function getJoins(): array
public function join(
array|string|TableIdentifier $name,
string|Predicate\PredicateInterface $on,
array|int|string $columns = [Select::SQL_STAR],
array|string $columns = [Select::SQL_STAR],
string $type = self::JOIN_INNER
): static {
if (is_array($name) && (! is_string(key($name)) || count($name) !== 1)) {
Expand Down