Add missing ext/operator documentation#4669
Conversation
|
I would like to note that since this is a new documentation the workflow run https://github.com/php/doc-en/actions/runs/14958493251/job/42050000015 is going to fail until the related pull request php/doc-base#246 is merged. |
|
Great👍 |
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
|
Quick heads up... Given that PECL was deprecated (after this PR was opened) I believe the references to PECL in this PR should be removed. |
I am trying to update this to use PIE, but it is still using PECL. I have not yet had the time to do that yet. I will reorganize my todo list and move this up in priority. |
|
Hi @jb-lopez, I have previously stated that I would recommend you to move this extension to PIE. However given the historical record of this extension I am fine if this links to PECL for the moment. As for what blocks this PR, nothing really. And I would like to have this merged before an eventual passing or rejection of RFC to split third-party extensions for the docs. The reason is that if this is merged, we can do a lift and shift rather than that we have to deal with an open PR that needs to target a different repository. We have recently introduced a sniffer tool (Docbook-CS). I would like to request you to rebase this PR with the master. That will give you some violations (like para to simpara). Once those are resolved (shouldn't be too difficult). We will merge the extension. |
5 participants
This pull request is to add the missing documentation for the PECL operator extension. I have taken over as the lead maintainer for that extension, but this is my first contribution to the PHP documentation so any feedback is welcome. There is a companion pull request to
doc-basethat goes with one and is required by this one. php/doc-base#246There appears to never have been any documentation for the PECL operator extension. For this pull request I've added the test class that ext/operator uses all of its overloading capabilities as a complete code sample.