Skip to content

ext/uri, ext/standard – URL parsing: improve error reporting using detailed url_error codes#22245

Open
arshidkv12 wants to merge 2 commits into
php:masterfrom
arshidkv12:url-2
Open

ext/uri, ext/standard – URL parsing: improve error reporting using detailed url_error codes#22245
arshidkv12 wants to merge 2 commits into
php:masterfrom
arshidkv12:url-2

Conversation

@arshidkv12
Copy link
Copy Markdown
Contributor

Replace generic URL parse failure warning with specific error messages
based on php_url_parse_ex2() error codes (invalid port, trailing colon,
port too long, empty host, etc.).

+		 switch (url_error) {
+            case PHP_URL_ERR_INVALID_PORT:
+                php_error_docref(NULL, E_WARNING, "Invalid port in URL");
+                break;
+            case PHP_URL_ERR_TRAILING_COLON:
+                php_error_docref(NULL, E_WARNING, "Trailing colon without port in URL");
+                break;
+            case PHP_URL_ERR_PORT_TOO_LONG:
+                php_error_docref(NULL, E_WARNING, "Port number too long in URL");
+                break;
+            case PHP_URL_ERR_EMPTY_HOST:
+                php_error_docref(NULL, E_WARNING, "Empty host in URL");
+                break;
+            default:
+                php_error_docref(NULL, E_WARNING, "Unable to parse URL");
+                break;
+        }

@arshidkv12 arshidkv12 changed the title url parsing: improve error reporting using detailed url_error codes ext/uri, ext/standard - url parsing: improve error reporting using detailed url_error codes Jun 7, 2026
@arshidkv12 arshidkv12 changed the title ext/uri, ext/standard - url parsing: improve error reporting using detailed url_error codes ext/uri, ext/standard – URL parsing: improve error reporting using detailed url_error codes Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant