ext/standard: Fix setlocale() NUL byte truncation#22843
Open
LamentXU123 wants to merge 12 commits into
Open
Conversation
Girgias
reviewed
Jul 21, 2026
jorgsowa
reviewed
Jul 21, 2026
arnaud-lb
reviewed
Jul 24, 2026
arnaud-lb
reviewed
Jul 24, 2026
| zend_wrong_parameter_type_error(i + 2, Z_EXPECTED_STRING_OR_NULL, &args[i]); | ||
| goto out; | ||
| } | ||
| num_args = 1; |
Member
There was a problem hiding this comment.
I suggest to throw if num_args > 1 here, otherwise we silently ignore extra args
Member
Author
There was a problem hiding this comment.
In which case we need to throw an ArgumentCountError when locale is an array and we have more than 2 args
Member
There was a problem hiding this comment.
The num_args = 1 assignment can be dropped now :)
| zval *elem; | ||
| ZEND_HASH_FOREACH_VAL(Z_ARRVAL(args[i]), elem) { | ||
| result = try_setlocale_zval(cat, elem); | ||
| result = try_setlocale_zval(cat, elem, i + 2); |
Member
There was a problem hiding this comment.
This change is not necessary anymore as the array argument is always 2
LamentXU123
marked this pull request as draft
July 24, 2026 09:53
LamentXU123
marked this pull request as ready for review
July 24, 2026 09:55
Co-Authored-By: Jorg Adam Sowa <74921107+jorgsowa@users.noreply.github.com>
LamentXU123
force-pushed
the
NUL-standard
branch
from
July 24, 2026 14:25
d4d00b2 to
4b9c769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://3v4l.org/rHId2#v
New argument logic in
try_setlocale_zvalis inevitable because we need to know the argument position when we raise the ValueError (both the second and the third parameter of thesetlocalefunction have the truncation issue)