Use Effect Schema decoding in diagnostics parsers#3743
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
JSON.parsehandling with Effect Schema decoding for trace NDJSON records and Windows process JSON output.ProcessDiagnosticstests fromexpecttoassertand added an explicit tagged-error guard for narrowing.Why
This keeps diagnostics parsing more idiomatic Effect: JSON inputs now flow through Schema decoding, malformed input remains safely ignored/countable, and tests use the preferred
@effect/vitestassertion style.Checklist
Note
Replace JSON.parse with Effect Schema decoding in diagnostics parsers
JSON.parsetry/catch blocks inTraceDiagnostics.tsandProcessDiagnostics.tswithSchema.decodeUnknownOption-based decoders.WindowsProcessRecord,TraceRecord, andTraceEventRecordEffect Schema structs to validate parsed data; invalid records are silently dropped rather than causing exceptions.parseWindowsProcessRowsfor external use.typeofchecks are now excluded from results.Macroscope summarized edcebbd.