Skip to content

Remove locationmode warning - #5683

Merged
emilykl merged 3 commits into
v7.0from
remove-locationmode-warning
Jul 28, 2026
Merged

Remove locationmode warning#5683
emilykl merged 3 commits into
v7.0from
remove-locationmode-warning

Conversation

@emilykl

@emilykl emilykl commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Link to issue

Closes #5628

Description of change

The change mentioned in the deprecation warning has now happened, with the switch to plotly.js v4.0. The deprecation warning can therefore be removed.

Guidelines

Comment thread codegen/datatypes.py
)

# Add warning for 'country names' locationmode
if node.name_property in locationmode_traces:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can locationmode_traces also be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch

@emilykl
emilykl force-pushed the remove-locationmode-warning branch from ac91599 to 01ad43b Compare July 28, 2026 20:37
@emilykl
emilykl merged commit 623abd8 into v7.0 Jul 28, 2026
19 of 21 checks passed
@emilykl
emilykl deleted the remove-locationmode-warning branch July 28, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants