Fix build: remove duplicate coupon validation in bounty claim route#42
Merged
Conversation
…build PR #40's merge duplicated the coupon store-match + reuse validation, re-declaring `const coupon` (TS2451) and breaking typecheck on master. The first block already covers both checks more thoroughly (store-name text match + reuse check excluding the current bounty), so drop the redundant second copy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masteris currently red. PR #40's merge duplicated the coupon store-match + reuse validation block inapp/api/bounties/[id]/claim/route.ts, re-declaringconst coupon—TS2451: Cannot redeclare block-scoped variable 'coupon'— which failspnpm typecheckon every PR (surfaced on #41).The first block already performs both checks, and more thoroughly (store-name text match for free-text bounties + reuse check that excludes the current bounty id). This removes the redundant second copy. Typecheck passes.
🤖 Generated with Claude Code