fix(auth): compare webhook secrets by byte length#502
Open
rissrice2105-agent wants to merge 1 commit into
Open
fix(auth): compare webhook secrets by byte length#502rissrice2105-agent wants to merge 1 commit into
rissrice2105-agent wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timingSafeEqualBug
Both endpoints checked JavaScript character length before converting strings to buffers. An authorization value containing a multibyte character could have the same character count as the configured ASCII secret but a different byte length, causing
timingSafeEqualto throw and return a server error instead of a normal 401 response.Tests
git diff --check: passedNotes
The confirmation route regression test is included, but the current reused installation cannot load
@profullstack/stack/email; a fresh install is temporarily blocked by the minimum-release-age policy for today's package release. CI should exercise it with the current dependency set. No invoice will be sent until the PR is merged and accepted.