re-pin cppcheck suppression to line number#225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the line-pinned convention for the one cppcheck suppression that lost it.
In #222 the
ctuOneDefinitionRuleViolationsuppression fordata_structures_[l,r)/bit.hppwas made file-level as a quick fix after #220 shiftedstruct BITfrom line 14 to 15, breaking the pinned entry. We've since decided file-level suppressions are undesirable (they hide the check for the whole file), so this re-pins the entry to the current line:All other suppressions in the list were already line-pinned and are untouched. The related PR #224 (which would have made all suppressions file-level) has been closed.