maintenance: mark gcc-118291 pass-self sites; drop obsolete #define filter in grep check#231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small maintenance items from the post-C++23 review.
1. Mark the gcc-bug sites so the reverts don't get lost
The C++23 migration (#229) converted recursive lambdas to deducing
this, but 7 tree headers had to keep the pass-self idiom because their lambdas live inside member functions/constructors and hit gcc bug 118291 (wrong code with deducing-thislambdas in member context, present in gcc 14/15). That decision only existed in commit messages; nothing in the code said why these 7 files differ from the other 15.Added a one-line marker at each site:
Files:
hld.hpp,lca_rmq.hpp,linear_lca.hpp,tree_lift.hpp,hagerup_kth_par.hpp,ladder_decomposition.hpp,linear_kth_par.hpp. When a fixed gcc reaches CI/judge, grep for118291to find everything to re-convert.2. Drop the obsolete
#definefilter in the grep checkgrep_clangformat_cppcheck.shcarried:We're on C++23 and no
#definein the tree contains.begin()-style member calls anymore (verified: the filtered and unfiltered greps both come up empty). Removed the filter and the stale TODO; the check is now a single grep.Validation
clang-format --dry-run --Werrorpasses on all 7 changed headerslibrary/orlibrary_checker_aizu_tests/)