count_paths: define vl locally instead of relying on kactl NTT typedef#235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count_paths_rectangle.hppandcount_paths_triangle.hppuse thevltype alias without defining it — it silently leaks from kactl'sNumberTheoreticTransform.h(typedef vector<ll> vl;). If kactl ever renames or drops that typedef, these headers stop compiling.Fix: declare
using vl = vector<ll>;incount_paths_rectangle.hpp(triangle includes rectangle, so one definition covers both). This matches the existing pattern inwildcard_pattern_matching.hpp.Notes:
typedef— verified that redeclaration compiles clean with-Wall -Wextravlintokactl_macros.hpp/template.cpp: that would diverge from upstream KACTL's template (which defines onlyvi/pii/ll), i.e. change what the team hand-types at contest. The remaining ~20vector<ll>spell-outs are consistent with KACTL convention and left as-is.