collector/mdadm: report removed disks in node_md_disks#3750
Open
locker95 wants to merge 1 commit into
Open
Conversation
mdadm -D lists empty raid slots as "removed". Those show up as '_' in /proc/mdstat (DisksDown in procfs), but node_md_disks only had active/failed/spare. Expose state="removed" for that count. Left node_md_state alone — removed is a per-slot condition, not an array activity state. Fixes prometheus#2384 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
node_md_disksonly exposedactive/failed/spare. When a raidmember is gone, mdadm shows that slot as
removedand/proc/mdstatmarks it with
_(procfsDisksDown). That count was never exported.Why not
node_md_state{state="removed"}?The issue asked for that series, but "removed" is a component
state, not an array activity state. An array with a missing member is
still
active(often degraded). Putting it undernode_md_statewouldmix two different concepts. Same place as failed/spare is the right fit:
Alert example:
node_md_disks{state="removed"} > 0Changes
node_md_disks{state="removed"}frommdStat.DisksDownmd125(raid1 with one member missing, matching the issue)Test
Fixes #2384