Deprecate pvsystem.singlediode parameter ivcurve_pnts#1743
Merged
Conversation
Member
|
I think |
reepoi
force-pushed
the
singlediode-ivcurvepnts
branch
from
161522c to
4a1dfab
Compare
reepoi
changed the title
ivcurve_pnts from pvsystem.singlediodepvsystem.singlediode parameter ivcurve_pnts
cwhanse
approved these changes
May 31, 2023
cwhanse
reviewed
May 31, 2023
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
cwhanse
approved these changes
Jun 7, 2023
cwhanse
left a comment
cwhanse
left a comment
Member
There was a problem hiding this comment.
CI failure is codecov, ignorable.
Closed
kandersolar
reviewed
Jun 12, 2023
kandersolar
left a comment
kandersolar
left a comment
Member
There was a problem hiding this comment.
Sorry for the late review, I missed that this was tagged 0.10.0! Looks good to me overall; the only thing I see is that these deprecation warnings from the tests need to get cleaned up: https://github.com/pvlib/pvlib-python/actions/runs/5201899928/jobs/9382722429?pr=1743#step:9:69
Contributor
Author
|
Ok, I wrapped all the tests using |
kandersolar
reviewed
Jun 13, 2023
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
5 tasks
6 tasks
kandersolar
added
the
deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The
ivcurve_pntsparameter ofpvsystem.singlediodeis deprecated in favor of usingpvsystem.i_from_vandv_from_ito get additional points on an IV curve. The test cases anddocs/examples/iv-modeling/plot_singlediode.pyare updated. Also, a bug intools._golden_sect_DataFramewhere scalars were converted into 0d-arrays is fixed.pvsystem.singlediodereturns adictor apd.DataFrame. Adictis returned only when all inputs are scalars orivcurve_pnts > 0.