fix: don't abort the mirror run when a dependency download fails#101
Merged
philnewm merged 1 commit intoJul 14, 2026
Merged
Conversation
The HTTPError handling in Mirrorer.mirror() only covered the top-level requirement. A 404 (or any other HTTP error) on a transitive dependency propagated out of the dependency loop and aborted the entire mirror run, leaving a partial mirror. Catch the error per dependency, log it, and continue with the remaining dependencies, matching the existing handling of top-level requirements. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
grische
force-pushed
the
fix/continue-on-dep-download-error
branch
from
July 10, 2026 10:44
305fab9 to
cafcf0a
Compare
philnewm
approved these changes
Jul 14, 2026
philnewm
left a comment
philnewm
left a comment
Collaborator
There was a problem hiding this comment.
Great fix to ensure it doesn't aboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTPError handling in Mirrorer.mirror() only covered the top-level requirement. A 404 (or any other HTTP error) on a transitive dependency propagated out of the dependency loop and aborted the entire mirror run, leaving a partial mirror. Catch the error per dependency, log it, and continue with the remaining dependencies, matching the existing handling of top-level requirements.