Skip to content

fix: stream package files instead of reading them into memory #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grische wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: stream package files instead of reading them into memory #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion morgan/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import os
import pathlib
import re
import shutil
import urllib.parse
from typing import Any

Expand Down Expand Up @@ -201,8 +202,12 @@ def _serve_file(self, project, filename):

self.send_response(200)
self.send_header("Content-Type", ct)
self.send_header("Content-Length", str(path.stat().st_size))
self.end_headers()
self.wfile.write(path.read_bytes())
# stream the file instead of reading it into memory, package
# distributions can be several gigabytes in size
with path.open("rb") as fh:
shutil.copyfileobj(fh, self.wfile)


def run(
Expand Down