[3.15] gh-73458: Fix logging.config.listen() on a host without an IPv4 address (GH-154491)#154616
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-73458: Fix logging.config.listen() on a host without an IPv4 address (GH-154491)#154616miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
… address (pythonGH-154491) The server is created in a thread which set the "ready" event only after a successful start, so a failure to start left the caller waiting for that event forever. Set it also on failure. The receiver always used AF_INET, which fails if the host has no IPv4 address, for example if "localhost" is only aliased to ::1. Use the family of the first resolved address in such case. Also fixes pythongh-82076. (cherry picked from commit 45a10f5d711ebe1bce9c6b93c10bbc5fe5bdf392) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server is created in a thread which set the "ready" event only after a
successful start, so a failure to start left the caller waiting for that
event forever. Set it also on failure.
The receiver always used AF_INET, which fails if the host has no IPv4
address, for example if "localhost" is only aliased to ::1. Use the family
of the first resolved address in such case.
Also fixes gh-82076.
(cherry picked from commit 45a10f5)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com