Ignore the free-threaded Windows build output directories#154641
Open
gianghungtien wants to merge 1 commit into
Open
Ignore the free-threaded Windows build output directories#154641gianghungtien wants to merge 1 commit into
gianghungtien wants to merge 1 commit into
Conversation
PCbuild/python.props places free-threaded builds in win32t, amd64t, arm32t and arm64t, but only the GIL-enabled counterparts (win32, amd64, arm32, arm64) were listed in .gitignore, so a --disable-gil build leaves its output visible to git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #154586 at @zooba's suggestion.
PCbuild/python.propsgives free-threaded builds their own output directories, one per platform:cpython/PCbuild/python.props
Lines 55 to 62 in eef2349
.gitignorelists the four GIL-enabled directories (win32/,amd64/,arm32/,arm64/) but none of thetcounterparts, soPCbuild\build.bat --disable-gilleaves its entire output —.pdb,.lib,.exp,pybuilddir.txt, the copiedLICENSE.txt, and so on — showing up as untracked files. That is easy to sweep into a commit by accident, which is exactly what happened in #154586.This adds the four missing entries, keeping the list alphabetical.
Verified against a real
-p x64 -c Release --disable-gilbuild tree:git statusis clean afterwards, where it previously listed 140 build artifacts.arm32t/andarm64t/are included for symmetry with the props file; I have no ARM machine to build on, so those two are matched by inspection rather than by test.No behaviour change, so this needs the
skip newslabel.