fix(admin)!: require all create-security body params#44
Merged
johnpmitsch merged 1 commit intoJun 24, 2026
Merged
Conversation
The POST /endpoints/:id/security/* create endpoints reject requests with a 400 when a required body param is missing or blank. Reflect that in the typed surface so callers get a compile/type error instead of a server-side rejection, extending the same change already applied to create_jwt's kid. - core: CreateReferrerRequest.referrer, CreateIpRequest.ip, CreateJwtRequest.public_key, CreateJwtRequest.name are now required String; CreateRequestFilterRequest.method is now required Vec<String> - python: positional required args (no None defaults) - node: required struct fields (regenerated index.d.ts) - ruby: hash_require_string / hash_require_vec_string; rbs updated - examples and all four per-language READMEs updated create_token is unchanged (token is server-generated).
ErikTech
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
POST /endpoints/:id/security/*create endpoints reject requests with a 400 when a required body param is missing or blank. This makes those params required in the SDK's typed surface so callers get a compile/type error up front instead of a server-side rejection. It extends the same fix already applied tocreate_jwt'skid.Required fields, now non-optional across core + all bindings:
create_referrerreferrercreate_ipipcreate_jwtpublic_key,name(pluskid, already required)create_request_filtermethod(array)create_tokenis unchanged (the token is server-generated).This is a breaking change to the typed signatures (
fix(admin)!). No client-side empty-string/empty-array validation is added; the server remains the source of truth for blank values.Per-binding mechanics follow the existing
kidprecedent:Option<String>->String,Option<Vec<String>>->Vec<String>Nonedefaults); stubs regeneratedindex.d.tsregeneratedhash_require_string/hash_require_vec_string; RBS sigs updatedTest plan
cargo check(all crates) andjust lintpasscargo test -p quicknode-sdk --lib— 211 passed--features rust)just python-build,just node-build,just ruby-buildall pass; regenerated.pyiandindex.d.tsshow the params as requiredCloses DX-5868