Fix issues in ble_wifi_provisioner#765
Merged
kilograham merged 14 commits intoJul 1, 2026
Merged
Conversation
The set_credentials.py script is not working. We seem to need to set sm_set_authentication_requirements properly.
Contributor
Author
|
I need to ask BlueKitchen for advice on this... |
Provide the option to delete all bonding details. Tidy the code a bit
mringwal
reviewed
Jun 24, 2026
Contributor
Author
|
This is working well now. |
And drop the call to gatt_client_set_required_security_level, that's for a client? Remove assert - it was a bad idea. Separate wiping of bonds as it's useful for testing.
lurch
reviewed
Jun 25, 2026
lurch
reviewed
Jun 25, 2026
lurch
reviewed
Jun 25, 2026
Co-authored-by: Andrew Scheller <lurch@durge.org>
Co-authored-by: Andrew Scheller <lurch@durge.org>
This is a server example not a gatt client. Fix out of date comment.
We shouldn't be sending two packets in ATT_EVENT_CAN_SEND_NOW. The ssid and password are now write only anyway. Add a connection status instead. More tinkering in the script
lurch
reviewed
Jun 25, 2026
peterharperuk
changed the title
liamfraser
approved these changes
Jul 1, 2026
andygpz11
approved these changes
Jul 1, 2026
andygpz11
left a comment
andygpz11
left a comment
Contributor
There was a problem hiding this comment.
This all looks sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set_credentials.py script is not working.
We seem to need to set sm_set_authentication_requirements properly.