Fix response parsing in shaded builds and modernize test environment (Closes #363, Fixes #41, Fixes #333) - #346
Open
maheshshinde9100 wants to merge 2 commits into
Open
Conversation
to throw a clear RazorpayException if an entity class cannot be found, rather than failing with a NullPointerException
- Resolve response parsing errors in shaded/re-packaged environments (razorpay#333) - Update Mockito and Jacoco for modern JDK compatibility - Fix deprecated Mockito matchers in BaseTest
maheshshinde9100
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes response parsing failures when the SDK is shaded or relocated and modernizes the test infrastructure to support current Java versions.
Problem
ApiClient.javarelied on a hardcodedcom.razorpay.package name while resolving entity classes through reflection. When the SDK was shaded into a different namespace, reflection failed, resulting in response parsing errors reported in #41 and #333.The existing test setup also depended on legacy Mockito APIs that are incompatible with modern JDKs.
Changes
Use dynamic package resolution (
getClass().getPackage().getName()) instead of hardcoded package names.Add a safety check in
parseResponse().Upgrade Mockito to 4.11.0.
Upgrade JaCoCo to 0.8.11.
Configure Maven Surefire for Java 17+ compatibility.
Replace deprecated Mockito APIs:
anyObject()→any()initMocks()→openMocks()Remove the duplicate
org.jsondependency frompom.xml.Impact
Verification
mvn clean compilemvn testCloses