Add page/per_page to watched and collection sync interfaces#7
Closed
yitzhaq wants to merge 1 commit into
Closed
Conversation
Trakt now paginates the /sync/watched and /sync/collection endpoints (trakt/trakt-api#775), returning only the first 100 items when no paging is requested. Unlike the ratings, history and watchlist interfaces, watched and collection had no way to pass page/limit, so callers could not fetch beyond the first page. Add page/per_page (mirroring the existing interfaces) and forward them as query parameters. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yitzhaq
force-pushed
the
paginate-watched-collection
branch
from
5bdd0a2 to
a759bc6
Compare
Author
|
Closing as obsolete: the REST-client rewrite (razzeee/script.trakt@9385020) removes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trakt paginates the
/sync/watchedand/sync/collectionendpoints (trakt-api discussion #775) and returns only the first 100 items when no pagination is requested. Thewatchedandcollectioninterfaces currently provide no way to passpage/limit, unlikeratings,historyandwatchlistwhich already acceptpage/per_page.This adds
page/per_pagetoSyncWatchedInterface.getandSyncCollectionInterface.get, following the existing pattern in the other sync interfaces, and forwards them as query parameters so callers can page through the full result set.Nonevalues are dropped byTraktRequest.encode_query, so behaviour is unchanged when the parameters are omitted.This is needed by the corresponding
script.traktfix for the Trakt→Kodi episode watched-status regression, where the season/episode breakdown now requires paging plusextended=progress.