fix: restore browser targets#165
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
概览在 变更构建工具目标配置
预计代码审查工作量🎯 1 (微小) | ⏱️ ~3 分钟 诗
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the .fatherrc.js configuration file to target Internet Explorer 11 (ie: 11). There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 80.08% 80.08%
=======================================
Files 6 6
Lines 673 673
Branches 166 166
=======================================
Hits 539 539
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| plugins: ['@rc-component/father-plugin'], | ||
| targets: { | ||
| ie: 11, | ||
| }, |
There was a problem hiding this comment.
这个是#164 最近升级了 @rc-component/father-plugin;的2.x版本的问题;
Summary
@rc-component/father-pluginenabled.esandliboutput.Root Cause
@rc-component/father-plugin@2.2.0defaultstargetsto{ chrome: 85 }, which is newer than the previous Father browser default. As a result, the published qrcode output keptstatic #_private fields inqrcodegen.js, and older webpack parsers failed withUnexpected character #.Verification
npm run compileacorn@6parseses/libs/qrcodegen.jsandlib/libs/qrcodegen.jsafter the fixnpm test -- --runInBandFixes #164
Summary by CodeRabbit