Drop RCT_EXPORT_METHOD from RCTAccessibilityManager TurboModule#57672
Open
christophpurrer wants to merge 2 commits into
Open
Drop RCT_EXPORT_METHOD from RCTAccessibilityManager TurboModule#57672christophpurrer wants to merge 2 commits into
christophpurrer wants to merge 2 commits into
Conversation
Summary: Changelog: [Internal] `RCTClipboard` is a pure TurboModule: it conforms to `NativeClipboardSpec` and implements `getTurboModule:` returning `NativeClipboardSpecJSI`. For TurboModules, the JS->ObjC dispatch is driven by codegen (the generated spec supplies the `selector` and `TurboModuleMethodValueKind`, invoked at runtime via `NSMethodSignature`/`NSInvocation`), not by the `RCT_EXPORT_METHOD` macro's `__rct_export__` metadata. `setString:` and `getString:reject:` are async-void methods whose parameters are all concrete types (`NSString *`, promise blocks) — none is a generic `id` requiring `RCTConvert` coercion — so the macro is not functionally required. Convert both to plain ObjC method declarations; conformance to the codegen'd `NativeClipboardSpec` protocol keeps compiler-enforced signature parity. This is a signature-only refactor with no change to the JS-facing API (the codegen spec). The macro is intentionally retained elsewhere: sync methods, methods with `id` params relying on `RCTConvert`, and modules reachable via the legacy bridge/interop layer still need it. Differential Revision: D113568495
Summary: Changelog: [Internal] `RCTAccessibilityManager` is a TurboModule: it conforms to `NativeAccessibilityManagerSpec` and implements `getTurboModule:` returning the codegen'd `...SpecJSI`. For TurboModules, the JS->ObjC dispatch is driven by codegen (the generated spec supplies the `selector` and argument kinds, invoked at runtime via `NSMethodSignature` / `NSInvocation`), not by the `RCT_EXPORT_METHOD` macro's `__rct_export__` metadata. The exported methods here are async-void with concrete parameter types (no generic `id` requiring `RCTConvert` coercion), so the macro is not functionally required. Convert them to plain ObjC method declarations; conformance to the codegen'd `NativeAccessibilityManagerSpec` protocol keeps compiler-enforced signature parity. Signature-only refactor with no change to the JS-facing API. Sync methods, methods with `id` params, and `constantsToExport` are intentionally left untouched. Differential Revision: D113579886
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113579886. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
RCTAccessibilityManageris a TurboModule: it conforms toNativeAccessibilityManagerSpecand implementsgetTurboModule:returning the codegen'd...SpecJSI. For TurboModules, theJS->ObjC dispatch is driven by codegen (the generated spec supplies the
selectorand argument kinds, invoked at runtime viaNSMethodSignature/NSInvocation), not by theRCT_EXPORT_METHODmacro's__rct_export__metadata.
The exported methods here are async-void with concrete parameter types (no
generic
idrequiringRCTConvertcoercion), so the macro is not functionallyrequired. Convert them to plain ObjC method declarations; conformance to the
codegen'd
NativeAccessibilityManagerSpecprotocol keeps compiler-enforced signature parity.Signature-only refactor with no change to the JS-facing API. Sync methods,
methods with
idparams, andconstantsToExportare intentionally leftuntouched.
Differential Revision: D113579886