Add missing strictMode prop to FlatList TypeScript types#57674
Conversation
strictMode is implemented in FlatList and declared in the Flow types, but absent from the TypeScript definitions, forcing TS users to augment the module to set it. Add it to FlatListProps to match the Flow declaration and runtime.
|
Hi @drhops! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D113631325. |
Summary:
FlatList's
strictModeprop is implemented in the component and declared in the Flow types (OptionalFlatListProps in FlatList.js), but missing from the shipped TypeScript definitions. TS users can't set it on without augmenting the module themselves. This addsstrictMode?: booleanto the TypeScript FlatListProps, matching the Flow declaration. Types-only, no runtime change.Changelog:
[GENERAL] [ADDED] - Add missing strictMode prop to FlatList TypeScript types
Test Plan:
Types-only change:
<FlatList ... strictMode />errored(Property 'strictMode' does not exist);render(): const renderer = strictMode ? this._memoizedRenderer : this._renderer;