Update various dependencies with fresh package-lock.json + associated fixes#494
Open
MoOx wants to merge 1 commit into
Open
Update various dependencies with fresh package-lock.json + associated fixes#494MoOx wants to merge 1 commit into
MoOx wants to merge 1 commit into
Conversation
… fixes Regenerating the lockfile bumped webpack to ≥5.100, whose stricter ProgressPlugin validation is incompatible with webpackbar 6 (pulled in by Docusaurus 3.8.1), breaking `npm install` on the postinstall build. So this includes: - Update Docusaurus 3.8.1 → 3.10.1 (ships webpackbar 7, fixes the install) - Update lint-staged → ^16.4.0 (fixes micromatch/yaml ReDoS advisories) - Update eslint-plugin-react-hooks canary → ^7.1.1 - Update next → ^15.5.18 within v15 - Use caret ranges for external deps in non-published workspaces (examples, website, tooling) to ease future lockfile updates If I interpreted npm audit properly, remaining issues are related to: - nextjs (postcss <8.5.10) - docusaurus (serialize-javascript <=7.0.4, uuid <11.1.1) - expo (uuid <11.1.1) So those are not an issues for package consumer anyway. Merging this might close some dependabots PR automatically.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates dependency versions across multiple package.json files, primarily switching from pinned to caret-ranged versions and bumping some dependencies (Docusaurus, eslint-plugin-react-hooks, lint-staged) to newer versions.
Changes:
- Convert exact version pins to caret ranges (
^) for several dependencies (yargs, react, react-dom, react-native, next, etc.). - Bump
@docusaurus/*packages from 3.8.1 to ^3.10.1 in the website package. - Upgrade
eslint-plugin-react-hooksfrom a canary build to ^7.1.1 andlint-stagedfrom ^13.0.3 to ^16.4.0 in the root.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumps eslint-plugin-react-hooks, lint-staged, and loosens version pins for prettier-plugin-hermes-parser and yargs. |
| apps/expo-app/package.json | Loosens react, react-dom, and react-native to caret ranges. |
| apps/nextjs-app/package.json | Bumps next to ^15.5.18 and loosens react/react-dom/eslint-config-next pins. |
| apps/platform-tests/package.json | Loosens react, react-dom, and react-native to caret ranges. |
| packages/benchmarks/package.json | Loosens yargs to caret range. |
| packages/scripts/package.json | Loosens yargs to caret range. |
| packages/website/package.json | Bumps Docusaurus packages to ^3.10.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "jest-environment-jsdom": "^29.7.0", | ||
| "jscodeshift": "^0.15.2", | ||
| "lint-staged": "^13.0.3", | ||
| "lint-staged": "^16.4.0", |
| "eslint-plugin-promise": "^6.0.0", | ||
| "eslint-plugin-react": "^7.33.1", | ||
| "eslint-plugin-react-hooks": "6.1.0-canary-12bc60f5-20250613", | ||
| "eslint-plugin-react-hooks": "^7.1.1", |
Comment on lines
+17
to
+19
| "react": "^19.2.0", | ||
| "react-dom": "^19.2.0", | ||
| "react-native": "^0.83.6", |
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a bunch of dependabots PR pending. Too many I would say.
This PR aims to reduce this number, even if most of those issues are not really concerning the end user of RSD, it's still bothering us somehow.
Regenerating the lockfile bumped webpack to ≥5.100, whose stricter ProgressPlugin validation is incompatible with webpackbar 6 (pulled in by Docusaurus 3.8.1), breaking
npm installon the postinstall build.So this includes:
If I interpreted npm audit properly, remaining issues are related to:
So those are not an issues for package consumer anyway.
Merging this might close some dependabots PR automatically.