Migrate JavaCoder to swift-java-jni-core#14
Conversation
Replace the readdle/java_swift dependency with swiftlang's official swift-java-jni-core (SwiftJavaJNICore), keeping JavaCoder's source effectively unchanged.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b9e79d. Configure here.
| let args = [jvalue(l: javaName)] | ||
| let clazz: jclass? = args.withUnsafeBufferPointer { ptr in | ||
| api.CallObjectMethodA(env, classLoader, loadClassMethodID, ptr.baseAddress) | ||
| } |
There was a problem hiding this comment.
loadClass gets slash names
High Severity
When a context classLoader is set, FindClass resolves classes via ClassLoader.loadClass(String), but it passes the JNI internal name (slashes, e.g. java/lang/Integer) instead of the binary name Java expects (dots). Class lookup fails on Android after JNIBootstrap.captureContextClassLoader().
Reviewed by Cursor Bugbot for commit 5b9e79d. Configure here.
| let args = [jvalue(l: javaName)] | ||
| let clazz: jclass? = args.withUnsafeBufferPointer { ptr in | ||
| api.CallObjectMethodA(env, classLoader, loadClassMethodID, ptr.baseAddress) | ||
| } |
There was a problem hiding this comment.
Nil method ID JNI call
Medium Severity
If GetMethodID for loadClass fails, loadClassMethodID stays nil but CallObjectMethodA is still invoked with that nil method ID when using the context class loader, which can crash native code or behave unpredictably.
Reviewed by Cursor Bugbot for commit 5b9e79d. Configure here.
1 participant
Note
High Risk
This is a full JNI stack swap affecting class loading, JVM registration, and string bridging; Android apps must register the shared JVM and may need
captureContextClassLoader(), and subtle JNI behavior differences can break existing integrations.Overview
Replaces the external readdle/java_swift dependency with swiftlang/swift-java-jni-core, while keeping a local
java_swiftlibrary that re-exports the oldJNI/JNICore/JNIObjectsurface on top of SwiftJavaJNICore. Package.swift moves to Swift tools 6.0, splits JavaCoder into its own target path, and publishes both JavaCoder and java_swift products.JavaCoder gains
JavaBridgeable.swift(Codable ↔jobject,Throwable, andError↔ Java exception bridging) so SwiftJava codegen no longer needs Readdle’s Java runtime.CAndroidNDKimports are dropped from config/primitive files.The shim adds
JNIBootstrap.captureContextClassLoader()for Android class resolution from non-JVM threads and does not ship its ownJNI_OnLoad(avoids clashing with SwiftJava). String encode/decode paths use UTF-16NewString/GetStringCharsinstead of modified UTF-8, fixing supplementary-character handling.Reviewed by Cursor Bugbot for commit 5b9e79d. Bugbot is set up for automated code reviews on this repo. Configure here.