fix: fall back to TLS trust when cluster CA path is missing#317
Draft
adietish wants to merge 10 commits into
Draft
fix: fall back to TLS trust when cluster CA path is missing#317adietish wants to merge 10 commits into
adietish wants to merge 10 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2bbcc72 to
995e113
Compare
Stale or missing certificate-authority file paths in kubeconfig must not break TLS trust resolution on a different machine. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Use the TLS trust established in the wizard for post-login API connections instead of kubeconfig CA settings or JVM default trust. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
b009333 to
ed859e6
Compare
Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Centralize kubeconfig cluster resolution in KubeConfigUtils as getClusterByServer and drop the duplicate from KubeConfigTlsUtils. Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Use the Certificate Authority input when establishing TLS context so user-provided paths and PEM data are honored before the trust dialog. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
8b4bfef to
bc40dfa
Compare
Parent trust prompts to the wizard, use invokeLater instead of invokeAndWait, and split TLS setup from authentication so API and OAuth certificates can both be accepted. Add TLS trust logging and surface OAuth discovery failures. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…odeFlow class Signed-off-by: Andre Dietisheim <adietish@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes eclipse-che/che#23878