Optimize FindQuery.update() with partial writes - #843
Open
lh0156 wants to merge 8 commits into
Open
Conversation
lh0156
marked this pull request as ready for review
July 30, 2026 09:12
Collaborator
|
Thanks for opening, @lh0156! I'll take a look ASAP. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 256a3c8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Implements #777 by updating matching records without materializing full Pydantic models.
What changed
FT.SEARCH ... NOCONTENTto collect matching keys page by page.HSETmappings forHashModel.JSON.SETcommands forJsonModel, including nested__paths.use_transactionflag and returns the number of updated records.Testing
pytest -q tests --ignore tests/test_benchmarks.py: 265 passed.pytest -q tests/test_hash_model.py tests/test_json_model.py: 147 passed.ruff checkandruff format --checkon changed source/tests.python -m compileall -q aredis_om tests.bandit -q -r aredis_om/model/model.py -s B608.Redis Stack was run locally via Docker Compose for the integration tests; benchmark tests were excluded from the full run.
Note
Medium Risk
Bulk updates now bypass per-instance
save()and write directly to Redis, so behavior depends on the new serialization and TTL preservation matching prior semantics; scope is contained toFindQuery.update()with broad test coverage.Overview
FindQuery.update()no longer loads full models and re-saves them. It validates and serializes update values once, pagesFT.SEARCH … NOCONTENTto collect matching keys (ignoring.only()projections), then applies partialHSETmappings forHashModelorJSON.SETon dotted paths (including__nested fields) forJsonModel. Hash updates re-applyHEXPIREfor fields that had a positive TTL. The method now returns the count of updated records; docs reflect that.FindQuery.dict()/copy()also persistknnwhen cloning queries for the key-only search path.New unit tests cover validation-before-search, empty hash mappings, pagination, JSON paths, and Pydantic v1 field resolution; an integration test asserts bulk update preserves hash field TTLs.
Reviewed by Cursor Bugbot for commit 4ca575f. Bugbot is set up for automated code reviews on this repo. Configure here.